< Summary - Jellyfin

Information
Class: Emby.Server.Implementations.Library.Validators.ArtistsValidator
Assembly: Emby.Server.Implementations
File(s): /srv/git/jellyfin/Emby.Server.Implementations/Library/Validators/ArtistsValidator.cs
Line coverage
48%
Covered lines: 29
Uncovered lines: 31
Coverable lines: 60
Total lines: 147
Line coverage: 48.3%
Branch coverage
18%
Covered branches: 3
Total branches: 16
Branch coverage: 18.7%
Method coverage

Feature is only available for sponsors

Upgrade to PRO version

Coverage history

Coverage history 0 25 50 75 100 5/31/2026 - 12:15:44 AM Line coverage: 55.1% (27/49) Branch coverage: 16.6% (2/12) Total lines: 12210/29/2026 - 12:17:11 AM Line coverage: 48.3% (29/60) Branch coverage: 18.7% (3/16) Total lines: 147 5/31/2026 - 12:15:44 AM Line coverage: 55.1% (27/49) Branch coverage: 16.6% (2/12) Total lines: 12210/29/2026 - 12:17:11 AM Line coverage: 48.3% (29/60) Branch coverage: 18.7% (3/16) Total lines: 147

Coverage delta

Coverage delta 7 -7

Metrics

MethodBranch coverage Crap Score Cyclomatic complexity Line coverage
.ctor(...)100%11100%
Run()18.75%591644.64%

File(s)

/srv/git/jellyfin/Emby.Server.Implementations/Library/Validators/ArtistsValidator.cs

#LineLine coverage
 1using System;
 2using System.Collections.Generic;
 3using System.Globalization;
 4using System.Linq;
 5using System.Threading;
 6using System.Threading.Tasks;
 7using Jellyfin.Data.Enums;
 8using MediaBrowser.Controller.Entities;
 9using MediaBrowser.Controller.Entities.Audio;
 10using MediaBrowser.Controller.Library;
 11using MediaBrowser.Controller.Persistence;
 12using Microsoft.Extensions.Logging;
 13
 14namespace Emby.Server.Implementations.Library.Validators;
 15
 16/// <summary>
 17/// Class ArtistsValidator.
 18/// </summary>
 19public class ArtistsValidator
 20{
 21    /// <summary>
 22    /// The library manager.
 23    /// </summary>
 24    private readonly ILibraryManager _libraryManager;
 25
 26    /// <summary>
 27    /// The logger.
 28    /// </summary>
 29    private readonly ILogger<ArtistsValidator> _logger;
 30    private readonly IItemRepository _itemRepo;
 31
 32    /// <summary>
 33    /// Initializes a new instance of the <see cref="ArtistsValidator" /> class.
 34    /// </summary>
 35    /// <param name="libraryManager">The library manager.</param>
 36    /// <param name="logger">The logger.</param>
 37    /// <param name="itemRepo">The item repository.</param>
 38    public ArtistsValidator(ILibraryManager libraryManager, ILogger<ArtistsValidator> logger, IItemRepository itemRepo)
 39    {
 2040        _libraryManager = libraryManager;
 2041        _logger = logger;
 2042        _itemRepo = itemRepo;
 2043    }
 44
 45    /// <summary>
 46    /// Runs the specified progress.
 47    /// </summary>
 48    /// <param name="progress">The progress.</param>
 49    /// <param name="cancellationToken">The cancellation token.</param>
 50    /// <returns>Task.</returns>
 51    public async Task Run(IProgress<double> progress, CancellationToken cancellationToken)
 52    {
 2053        var names = _itemRepo.GetAllArtistNames();
 2054        var existingArtistIds = _libraryManager.GetItemIds(new InternalItemsQuery
 2055        {
 2056            IncludeItemTypes = [BaseItemKind.MusicArtist]
 2057        }).ToHashSet();
 58
 2059        var existingArtists = _libraryManager.GetArtists(names);
 60
 2061        var numComplete = 0;
 2062        var count = names.Count;
 2063        var refreshed = 0;
 64
 2065        var liveIds = new HashSet<Guid>();
 2066        var unresolved = 0;
 67
 4068        foreach (var name in names)
 69        {
 70            try
 71            {
 072                MusicArtist? item = null;
 073                if (existingArtists.TryGetValue(name, out var artists) && artists.Length > 0)
 74                {
 075                    item = artists.OrderBy(i => i.IsAccessedByName ? 1 : 0).First();
 76                }
 77
 78                // Fall back to GetArtist if not found (creates new item if needed)
 079                item ??= _libraryManager.GetArtist(name);
 80
 81                // A name with no item is nothing to refresh, and nothing to keep alive either.
 082                if (item is not null)
 83                {
 084                    liveIds.Add(item.Id);
 85
 086                    var isNew = !existingArtistIds.Contains(item.Id);
 087                    var neverRefreshed = item.DateLastRefreshed == default;
 88
 089                    if (isNew || neverRefreshed)
 90                    {
 091                        await item.RefreshMetadata(cancellationToken).ConfigureAwait(false);
 092                        refreshed++;
 93                    }
 94                }
 095            }
 096            catch (OperationCanceledException)
 97            {
 098                throw;
 99            }
 0100            catch (Exception ex)
 101            {
 0102                unresolved++;
 0103                _logger.LogError(ex, "Error refreshing {ArtistName}", name);
 0104            }
 105
 0106            numComplete++;
 0107            double percent = numComplete;
 0108            percent /= count;
 0109            percent *= 100;
 110
 0111            progress.Report(percent);
 0112        }
 113
 20114        _logger.LogInformation("Refreshed metadata for {RefreshedCount} new artists out of {TotalCount} total", refreshe
 115
 116        // Every name that threw is a name whose artist is missing from the live set, and deleting against
 117        // a live set with holes in it deletes artists the library still refers to. Leave the sweep to a
 118        // run that got a clean read of them.
 20119        if (unresolved > 0)
 120        {
 0121            _logger.LogWarning(
 0122                "Not removing dead artists: {Count} of {TotalCount} names could not be resolved this run",
 0123                unresolved,
 0124                count);
 125
 0126            progress.Report(100);
 0127            return;
 128        }
 129
 20130        var deadEntities = _libraryManager.GetItemList(new InternalItemsQuery
 20131        {
 20132            IncludeItemTypes = [BaseItemKind.MusicArtist],
 20133            IsLocked = false
 20134        }).OfType<MusicArtist>()
 20135        .Where(item => item.IsAccessedByName && !liveIds.Contains(item.Id))
 20136        .ToList();
 137
 40138        foreach (var item in deadEntities)
 139        {
 0140            _logger.LogInformation("Deleting dead {ItemType} {ItemId} {ItemName}", item.GetType().Name, item.Id.ToString
 141        }
 142
 20143        _libraryManager.DeleteItemsUnsafeFast(deadEntities, deleteSourceFiles: true);
 144
 20145        progress.Report(100);
 20146    }
 147}